Add a trailing slash to the root pattern#5464
Merged
mjesun merged 1 commit intojestjs:masterfrom Feb 5, 2018
mjesun:fix-root-pattern
Merged
Add a trailing slash to the root pattern#5464mjesun merged 1 commit intojestjs:masterfrom mjesun:fix-root-pattern
mjesun merged 1 commit intojestjs:masterfrom
mjesun:fix-root-pattern
Conversation
thymikee
approved these changes
Feb 5, 2018
Codecov Report
@@ Coverage Diff @@
## master #5464 +/- ##
==========================================
+ Coverage 62.19% 62.22% +0.02%
==========================================
Files 205 205
Lines 6930 6930
Branches 3 3
==========================================
+ Hits 4310 4312 +2
+ Misses 2619 2617 -2
Partials 1 1
Continue to review full report at Codecov.
|
Member
|
changelog |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When verifying if a test belongs to a particular project, the root of the project is part of the checks we perform (
rootsis checked against the filename via a regular expression). However, the regular expression did not include a trailing slash (either/or\for Windows), which causes to wrongly recognize tests as part of a pattern. For instance:/foo/bar/folder./foo/bar/folder-with-something.All tests inside B are executed also through config A, since B starts with A. This leads to tests getting executed twice if not crashing. Adding a trailing slash fixes the problem.